feat: Implement some cluster commands #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
ShiKaiWi
reviewed
Sep 21, 2022
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
ShiKaiWi
reviewed
Sep 21, 2022
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* refactor: remove TableManipulator Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * remove stale file Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * impl more commands Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * fix clippy warning Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * address comments Signed-off-by: Ruihang Xia <waynestxia@gmail.com> Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #245
Rationale for this change
The
TableManageris changed in #260, some command implementations need to be re-implement.What changes are included in this PR?
TableManipulator.TableEngine, which is unnecessary.Open,Close,CreateandDropcommands. But they are going to be changed again in the later task of CombineVolatileCatalogandCluster#245 (with newMetaClientandMetaEndpoint)Are there any user-facing changes?
No for now
How does this change test
untested