refactor: centralize the logic of choosing worker #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! We really appreciate it. This project follows the Conventional Commit Guide. So, I have one suggestion for your PR. I think a more appropriate title
Titles like this are more clear and can explain what you have done. Conventions are sometimes annoying, but they make us easy to collaborate with each other. |
|
You can edit the PR title here: |
OK |
chunshao90
reviewed
Oct 18, 2022
archerny
changed the title
jiacai2050
reviewed
Oct 18, 2022
QuintinTao
requested review from
jiacai2050 and
chunshao90
and removed request for
jiacai2050 and
chunshao90
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* issue-268 * refactor: centralize the logic of choosing worker Co-authored-by: Arthur Chern <weirong.cwr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a function in the write_worker.rs to centralize the logic of choosing worker:
pub fn find_worker(table_id: usize, worker_num: usize) -> usize {
table_id % worker_num
}