Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing version for meta request #339

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

ShiKaiWi
Copy link
Member

Which issue does this PR close?

Closes #

Rationale for this change

The shard version in the heartbeat is not set now, which leading to wrong message to CeresMeta.

What changes are included in this PR?

  • Set the correct shard version in the message to CeresMeta;
  • Add log for handling requests from CeresMeta;

Are there any user-facing changes?

None.

How does this change test

No need to test.

Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 merged commit 28be2ed into apache:main Oct 24, 2022
@ShiKaiWi ShiKaiWi deleted the fix-missing-version branch January 18, 2023 06:56
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants