fix: apply missing filtering on parquet reader #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiKaiWi
force-pushed
the
fix-missing-filter
branch
from
771d7b0
to
bc60d9f
Compare
jiacai2050
requested changes
Nov 2, 2022
3 tasks
ShiKaiWi
force-pushed
the
fix-missing-filter
branch
from
308cb2a
to
874f847
Compare
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* fix: apply missing filtering on parquet reader * fix: refactor the sst reader based on parquet * chore: fix filter test * chore: rebase main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #363
Rationale for this change
After #351, the filter result about the row groups is not pushed down to parquet reading procedure.
What changes are included in this PR?
Are there any user-facing changes?
None.
How does this change test
Current module will be updated in the recent future, and more UT should be added later.