Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add table id to LogEntry #379

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

Rachelint
Copy link
Contributor

Which issue does this PR close?

Closes #378

Rationale for this change

See #378 .

What changes are included in this PR?

  • Add table id in LogEntry.
  • Modify related module.

Are there any user-facing changes?

None.

How does this change test

Test by exist ut.

@Rachelint Rachelint changed the title feat: add table id to LogEntry. feat: add table id to LogEntry Nov 8, 2022
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit a1b9b58 into apache:main Nov 8, 2022
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
@Rachelint Rachelint deleted the add-table-id-in-log-entry branch May 27, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return table id in LogEntry(wal's reading result)
2 participants