fix: drop bug of wal on mq, can't not drop runtime #433
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
Now, I found drop wal on mq may need to panic because dropping runtime in
drop()
.You can reproduce it using following cmd(need a kafka cluster):
The error message:
What changes are included in this PR?
Fix above bug.
Are there any user-facing changes?
User should manually call
close_gracefully
now.How does this change test
Test manually.