Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove size from sst metadata #513

Merged
merged 4 commits into from
Jan 3, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Dec 27, 2022

Which issue does this PR close?

Closes #321

Rationale for this change

What changes are included in this PR?

  1. Remove size, row_num from sst metadata. Those two fields cannot be known before write sst, so we have to store them in other place(manifest now).
  2. When read sst, pass one more arg: file_size, which is stored inside FileHandle.

Are there any user-facing changes?

No

How does this change test

Existing UT

@jiacai2050 jiacai2050 marked this pull request as ready for review December 27, 2022 10:05
analytic_engine/src/instance/flush_compaction.rs Outdated Show resolved Hide resolved
analytic_engine/src/sst/factory.rs Show resolved Hide resolved
analytic_engine/src/sst/file.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit 1195831 into apache:breaking-changes Jan 3, 2023
jiacai2050 added a commit that referenced this pull request Jan 4, 2023
* remove size from sst metadata

* pass file size from file handler

* run CI for breaking-changes branch

* fix CR
ShiKaiWi pushed a commit that referenced this pull request Jan 6, 2023
* remove size from sst metadata

* pass file size from file handler

* run CI for breaking-changes branch

* fix CR
ShiKaiWi pushed a commit that referenced this pull request Jan 12, 2023
* remove size from sst metadata

* pass file size from file handler

* run CI for breaking-changes branch

* fix CR
ShiKaiWi pushed a commit that referenced this pull request Jan 18, 2023
* remove size from sst metadata

* pass file size from file handler

* run CI for breaking-changes branch

* fix CR
ShiKaiWi pushed a commit that referenced this pull request Jan 18, 2023
* remove size from sst metadata

* pass file size from file handler

* run CI for breaking-changes branch

* fix CR
ShiKaiWi pushed a commit that referenced this pull request Jan 18, 2023
* remove size from sst metadata

* pass file size from file handler

* run CI for breaking-changes branch

* fix CR
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* remove size from sst metadata

* pass file size from file handler

* run CI for breaking-changes branch

* fix CR
@jiacai2050 jiacai2050 deleted the fix-sst-size branch November 22, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants