Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve the release profile and add release-slim profile #580

Merged
merged 3 commits into from
Jan 17, 2023

Conversation

ShiKaiWi
Copy link
Member

Which issue does this PR close?

Closes #

Rationale for this change

Current release profile is not the best concerning performance, and some options can be configured for better performance, but with slow compiling time and high memory consumption.

What changes are included in this PR?

  • Add lto=true and codegen-units=1 to release profile;
  • Remove better-release profile, and add release-slim profile for a smaller and slower binary;
  • Fix the bug that cargo-sort doesn't work in the precommit;

Are there any user-facing changes?

None.

How does this change test

Current ci.

Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit 0163f60 into apache:main Jan 17, 2023
@ShiKaiWi ShiKaiWi deleted the feat-release-profile branch January 18, 2023 06:54
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
…e#580)

* feat: improve the release profile and add release-slim profile

* adjust the order of the option for profile

* polish up the comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants