Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: store manifest to oss #607

Merged
merged 17 commits into from
Feb 9, 2023
Merged

feat: store manifest to oss #607

merged 17 commits into from
Feb 9, 2023

Conversation

ShiKaiWi
Copy link
Member

@ShiKaiWi ShiKaiWi commented Feb 2, 2023

Which issue does this PR close?

Closes #579

Rationale for this change

Details have been provided in the #579. The basic targes include:

  • Avoid any large log entry written to the WAL, which may lead to unrecoverable write/query failures;
  • Simplify the snapshot procedure with the help of ObjectStore.

What changes are included in this PR?

Implement the proposal: #579 (comment)

Are there any user-facing changes?

None.

How does this change test

Existing tests.

@ShiKaiWi ShiKaiWi force-pushed the feat-store-manifest-to-oss branch from b452577 to 4e6ec90 Compare February 2, 2023 13:33
@ShiKaiWi ShiKaiWi marked this pull request as ready for review February 5, 2023 15:57
@ShiKaiWi ShiKaiWi requested a review from Rachelint February 5, 2023 15:57
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2023 •
edited
Loading

Codecov Report

Merging #607 (1561cf2) into main (2306aac) will increase coverage by 0.01%.
The diff coverage is 70.51%.

@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
+ Coverage   66.07%   66.08%   +0.01%     
==========================================
  Files         284      285       +1     
  Lines       43799    44299     +500     
==========================================
+ Hits        28938    29275     +337     
- Misses      14861    15024     +163
Impacted Files Coverage Δ
analytic_engine/src/sst/reader.rs 92.30% <ø> (ø)
server/src/grpc/mod.rs 0.00% <ø> (ø)
server/src/grpc/storage_service/mod.rs 41.42% <0.00%> (ø)
server/src/grpc/storage_service/write.rs 38.99% <0.00%> (-3.67%) ⬇️
server/src/handlers/sql.rs 0.00% <0.00%> (ø)
server/src/http.rs 0.00% <0.00%> (ø)
server/src/mysql/worker.rs 0.00% <0.00%> (ø)
server/src/server.rs 0.00% <0.00%> (ø)
sql/src/partition.rs 0.00% <ø> (ø)
analytic_engine/src/sst/parquet/async_reader.rs 89.32% <66.66%> (-0.17%) ⬇️
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ShiKaiWi ShiKaiWi added feature New feature or request A-analytic-engine Area: Analytic Engine breaking-change Contains user-facing changes labels Feb 6, 2023
@jiacai2050
Copy link
Contributor

So many changes, could you point me which parts are most important to review?

@ShiKaiWi
Copy link
Member Author

ShiKaiWi commented Feb 7, 2023

So many changes, could you point me which parts are most important to review?

Actually, the massive changes result from the file path renaming: meta/details.rs -> manifest/details.rs. I will revert the renaming for a clean change set.

@ShiKaiWi ShiKaiWi force-pushed the feat-store-manifest-to-oss branch from ba5d1e4 to 755c71e Compare February 7, 2023 03:36
Rachelint
Rachelint reviewed Feb 7, 2023
View reviewed changes
analytic_engine/src/meta/details.rs Show resolved Hide resolved
analytic_engine/src/meta/details.rs Outdated Show resolved Hide resolved
analytic_engine/src/meta/details.rs Outdated Show resolved Hide resolved
analytic_engine/src/meta/details.rs Show resolved Hide resolved
analytic_engine/src/meta/details.rs Outdated Show resolved Hide resolved
jiacai2050
jiacai2050 approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi added this pull request to the merge queue Feb 9, 2023
Merged via the queue into apache:main with commit 2144405 Feb 9, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
@ShiKaiWi
feat: store manifest to oss (apache#607)
f6206fe 
* feat: store snapshot to object store

* Store snapshot to oss

* adapt to the new implementation

* support convestion for snapshot and current snapshot

* implement the SnapshotStore

* update unit test

* fix bug found by unit test

* fix some comments

* fix test_table_write_get_override_mem_wal caused by resetting seq of mem wal

* add TODO for delete logs after snapshotting

* refactor the manifest api: load_data

* remove debug println

* fix failure of ut

* rename mod manifest to meta

* address CR

* avoid indirect current snapshot file

* handle snapshot not exist
@ShiKaiWi ShiKaiWi deleted the feat-store-manifest-to-oss branch May 29, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunshao90 chunshao90 chunshao90 left review comments

@Rachelint Rachelint Rachelint left review comments

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
A-analytic-engine Area: Analytic Engine breaking-change Contains user-facing changes feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store snapshot of manifest to object store
5 participants
@ShiKaiWi @codecov-commenter @jiacai2050 @chunshao90 @Rachelint