Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support the simplest influxql raw query #710

Merged
merged 4 commits into from
Mar 9, 2023
Merged

feat: support the simplest influxql raw query #710

merged 4 commits into from
Mar 9, 2023

Conversation

Rachelint
Copy link
Contributor

Which issue does this PR close?

Closes #
Part of #698

Rationale for this change

After #683, we has prepared enough for supporting to do some simplest query by influxql.
In this pr, we add the support above.

What changes are included in this PR?

Are there any user-facing changes?

User can do some simple query by influxql now.

How does this change test

Test by ut and manually.

@Rachelint Rachelint force-pushed the add-statement-converter branch 2 times, most recently from 365d30f to 845055c Compare March 8, 2023 08:40
@Rachelint Rachelint requested review from jiacai2050 and ShiKaiWi March 8, 2023 08:43
@Rachelint Rachelint force-pushed the add-statement-converter branch from 845055c to 5549300 Compare March 8, 2023 08:46
@Rachelint Rachelint force-pushed the add-statement-converter branch from 5549300 to 7057334 Compare March 8, 2023 08:50
ShiKaiWi
ShiKaiWi reviewed Mar 8, 2023
View reviewed changes
server/src/handlers/query.rs Outdated Show resolved Hide resolved
sql/src/influxql/mod.rs Outdated Show resolved Hide resolved
sql/src/influxql/util.rs Outdated Show resolved Hide resolved
sql/src/influxql/test_util.rs Outdated Show resolved Hide resolved
ShiKaiWi
ShiKaiWi reviewed Mar 8, 2023
View reviewed changes
sql/src/influxql/select/rewriter.rs Outdated Show resolved Hide resolved
sql/src/influxql/select/converter.rs Outdated Show resolved Hide resolved
sql/src/influxql/select/converter.rs Outdated Show resolved Hide resolved
sql/src/influxql/select/converter.rs Outdated Show resolved Hide resolved
jiacai2050
jiacai2050 reviewed Mar 8, 2023
View reviewed changes
server/src/http.rs Show resolved Hide resolved
server/src/http.rs Outdated Show resolved Hide resolved
server/src/http.rs Show resolved Hide resolved
sql/src/influxql/select/converter.rs Show resolved Hide resolved
sql/src/influxql/select/converter.rs Outdated Show resolved Hide resolved
sql/src/influxql/select/mod.rs Outdated Show resolved Hide resolved
server/src/handlers/query.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #710 (06b4ed5) into main (95ea870) will increase coverage by 0.62%.
The diff coverage is 55.74%.

❗ Current head 06b4ed5 differs from pull request most recent head 7057334. Consider uploading reports for the commit 7057334 to get more accurate results

@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
+ Coverage   67.53%   68.16%   +0.62%     
==========================================
  Files         281      288       +7     
  Lines       44296    45130     +834     
==========================================
+ Hits        29916    30761     +845     
+ Misses      14380    14369      -11
Impacted Files Coverage Δ
analytic_engine/src/instance/close.rs 0.00% <ø> (ø)
analytic_engine/src/instance/open.rs 80.42% <ø> (+0.18%) ⬆️
analytic_engine/src/manifest/mod.rs 0.00% <ø> (ø)
analytic_engine/src/table/mod.rs 84.12% <ø> (+3.91%) ⬆️
server/src/grpc/meta_event_service/mod.rs 0.00% <0.00%> (ø)
...ver/src/grpc/meta_event_service/shard_operation.rs 0.00% <0.00%> (ø)
server/src/grpc/mod.rs 0.00% <0.00%> (ø)
server/src/grpc/storage_service/prom_query.rs 54.28% <0.00%> (-0.29%) ⬇️
server/src/grpc/storage_service/write.rs 38.99% <0.00%> (ø)
server/src/handlers/error.rs 0.00% <ø> (ø)
... and 52 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Rachelint Rachelint force-pushed the add-statement-converter branch 7 times, most recently from 5d3b0db to da65f29 Compare March 9, 2023 02:34
@Rachelint Rachelint force-pushed the add-statement-converter branch from da65f29 to 936cac5 Compare March 9, 2023 02:49
jiacai2050
jiacai2050 approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 enabled auto-merge March 9, 2023 02:54
@jiacai2050 jiacai2050 added this pull request to the merge queue Mar 9, 2023
Merged via the queue into apache:main with commit 15f066f Mar 9, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
@Rachelint
feat: support the simplest influxql raw query (apache#710)
1b607d9 
* add influxql statement converter(to sql statement).

* complete the influxql planner.

* add influxql http interface.

* address CR.
@Rachelint Rachelint deleted the add-statement-converter branch May 27, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiKaiWi ShiKaiWi ShiKaiWi left review comments

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rachelint @codecov-commenter @jiacai2050 @ShiKaiWi