-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new crate trace_metric
for collecting metrics in read procedure
#714
Conversation
89af927
to
8365129
Compare
8365129
to
3da8fe4
Compare
Codecov Report
@@ Coverage Diff @@
## main #714 +/- ##
==========================================
+ Coverage 68.26% 68.47% +0.20%
==========================================
Files 287 294 +7
Lines 45058 45675 +617
==========================================
+ Hits 30761 31276 +515
- Misses 14297 14399 +102
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
trace_metric
for collecting metrics in read procedure
Please give some example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…re (apache#714) * feat: add ReadMetricsCollector for collecting metrics in read procedure * collect metrics during merge * add new component trace_metric * add derive crate * impl proc macro for trace_metric * use the trace_metric crate * support optional collector * fix license * make collector is optional * trace metrics in parquet reader * rename Collector to MetricsCollector * rename TracedMetrics to TraceMetricWhenDrop * support FormatCollectorVisitor * set the metrics into datafusion * remove useless file * remove useless module * rename constant variable * fix wrong field name in metrics * address CR * attach index to the merge iter's metrics collector * rename some constant variables * fix wrong variable name * rename metric type
Which issue does this PR close?
Closes #696
Rationale for this change
Refer to #696
What changes are included in this PR?
trace_metric
crate for collecting the metrics during the codebase;Are there any user-facing changes?
When using
explain analyze [sql]
, it will output the metrics about the scan table. Here is an example:How does this change test
Existing tests.