Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: block all query requests #751

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

MichaelLeeHZ
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

Sometimes, I may want CeresDB to block all query and write requests. For instance, if CeresDB is experiencing a memory leak, I might want to investigate whether queries cause this. In such situations, blocking all requests can be useful.

What changes are included in this PR?

  • add a block rule to block all query request
  • add a block rule to block all write request

Are there any user-facing changes?

How does this change test

By unit test

@MichaelLeeHZ MichaelLeeHZ marked this pull request as ready for review March 20, 2023 11:58
server/src/limiter.rs Outdated Show resolved Hide resolved
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi added this pull request to the merge queue Mar 22, 2023
@ShiKaiWi ShiKaiWi merged commit ee0bcdf into apache:main Mar 22, 2023
@MichaelLeeHZ MichaelLeeHZ deleted the feat_block_all_query branch April 13, 2023 02:10
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* block all query or insert requests

* rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants