-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support split write request to batches for small wal logs #754
Conversation
Codecov Report
@@ Coverage Diff @@
## main #754 +/- ##
==========================================
+ Coverage 68.24% 68.30% +0.06%
==========================================
Files 296 296
Lines 46011 46306 +295
==========================================
+ Hits 31399 31630 +231
- Misses 14612 14676 +64
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cef70ce
to
dabfa4e
Compare
…he#754) * feat: support split write request to batches for small wal logs * test: add unit test for the split write requests * fix: rename the config option name * chore: add some comments * chore: explain that `max_bytes_per_write_batch` will break atomicity * refactor: do maybe_split_write_request
Which issue does this PR close?
Closes #
Rationale for this change
Currently, one large write request may lead to one large WAL log, which is not friendly for some wal implementations.
What changes are included in this PR?
Are there any user-facing changes?
None.
How does this change test
New unit tests and existing integraion tests.