Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix insert-license pre-commit #756

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Mar 23, 2023

Which issue does this PR close?

Closes #

Rationale for this change

What changes are included in this PR?

Update license insert, add use-current-year

Are there any user-facing changes?

  • When edit old file, pre-commit will update license header to 2022-{current-year}

How does this change test

Manually.

This is what other project does:

It seems year format is not very strict, and we can define format used in CeresDB.

@codecov-commenter
Copy link

Codecov Report

Merging #756 (dede125) into main (99f2cf4) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head dede125 differs from pull request most recent head 3bfc05d. Consider uploading reports for the commit 3bfc05d to get more accurate results

@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
- Coverage   68.20%   68.16%   -0.04%     
==========================================
  Files         296      296              
  Lines       46057    46057              
==========================================
- Hits        31411    31395      -16     
- Misses      14646    14662      +16     

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi added this pull request to the merge queue Mar 27, 2023
Merged via the queue into apache:main with commit 32bd51e Mar 27, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants