Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add metrics for write procedure #831

Merged
merged 4 commits into from
Apr 12, 2023
Merged

feat: add metrics for write procedure #831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c2426a0
feat: metrics for all write stages
ShiKaiWi Apr 12, 2023
5f675b8
feat: record the metrics in the write procedure
ShiKaiWi Apr 12, 2023
f876a19
feat: rename some labels
ShiKaiWi Apr 12, 2023
467b19d
feat: add more metrics
ShiKaiWi Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions analytic_engine/src/instance/write.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2022 CeresDB Project Authors. Licensed under Apache-2.0.
// Copyright 2022-2023 CeresDB Project Authors. Licensed under Apache-2.0.

//! Write logic of instance

Expand Down Expand Up @@ -292,14 +292,17 @@ impl Instance {
table_data: &TableDataRef,
request: WriteRequest,
) -> Result<usize> {
let _timer = table_data.metrics.start_table_write_timer();
let mut encode_ctx = EncodeContext::new(request.row_group);

self.preprocess_write(worker_local, space, table_data, &mut encode_ctx)
.await?;

// let table_data = space_table.table_data();
let schema = table_data.schema();
encode_ctx.encode_rows(&schema)?;
{
let _timer = table_data.metrics.start_table_write_encode_timer();
let schema = table_data.schema();
encode_ctx.encode_rows(&schema)?;
}

let EncodeContext {
row_group,
Expand Down Expand Up @@ -441,6 +444,7 @@ impl Instance {
table_data: &TableDataRef,
encode_ctx: &mut EncodeContext,
) -> Result<()> {
let _total_timer = table_data.metrics.start_table_write_preprocess_timer();
ensure!(
!table_data.is_dropped(),
WriteDroppedTable {
Expand Down Expand Up @@ -486,6 +490,10 @@ impl Instance {
space.id,
self.db_write_buffer_size,
);

let _timer = table_data
ShiKaiWi marked this conversation as resolved.
Show resolved Hide resolved
.metrics
.start_table_write_instance_flush_wait_timer();
self.handle_memtable_flush(worker_local, &table).await?;
}
}
Expand All @@ -499,11 +507,16 @@ impl Instance {
space.id,
space.write_buffer_size,
);

let _timer = table_data
.metrics
.start_table_write_space_flush_wait_timer();
self.handle_memtable_flush(worker_local, &table).await?;
}
}

if table_data.should_flush_table(worker_local) {
let _timer = table_data.metrics.start_table_write_flush_wait_timer();
self.handle_memtable_flush(worker_local, table_data).await?;
}

Expand All @@ -517,6 +530,8 @@ impl Instance {
table_data: &TableData,
encoded_rows: Vec<ByteVec>,
) -> Result<SequenceNumber> {
let _timer = table_data.metrics.start_table_write_wal_timer();
ShiKaiWi marked this conversation as resolved.
Show resolved Hide resolved

worker_local
.ensure_permission(
&table_data.name,
Expand Down Expand Up @@ -574,6 +589,8 @@ impl Instance {
row_group: &RowGroupSlicer,
index_in_writer: IndexInWriterSchema,
) -> Result<()> {
let _timer = table_data.metrics.start_table_write_memtable_timer();

if row_group.is_empty() {
return Ok(());
}
Expand Down
82 changes: 76 additions & 6 deletions analytic_engine/src/table/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ lazy_static! {
)
.unwrap();

static ref TABLE_WRITE_BATCH_HISTGRAM: Histogram = register_histogram!(
static ref TABLE_WRITE_BATCH_HISTOGRAM: Histogram = register_histogram!(
"table_write_batch_size",
"Histgram of write batch size",
"Histogram of write batch size",
vec![10.0, 50.0, 100.0, 500.0, 1000.0, 5000.0]
)
.unwrap();
Expand Down Expand Up @@ -96,9 +96,10 @@ lazy_static! {
).unwrap();

// Buckets: 0, 0.01, .., 0.01 * 2^12
static ref TABLE_WRITE_STALL_DURATION_HISTOGRAM: Histogram = register_histogram!(
"table_write_stall_duration",
static ref TABLE_WRITE_DURATION_HISTOGRAM: HistogramVec = register_histogram_vec!(
"table_write_duration",
"Histogram for write stall duration of the table in seconds",
&["type"],
exponential_buckets(0.01, 2.0, 13).unwrap()
).unwrap();

Expand Down Expand Up @@ -134,6 +135,16 @@ pub struct Metrics {
compaction_output_sst_size_histogram: Histogram,
compaction_input_sst_row_num_histogram: Histogram,
compaction_output_sst_row_num_histogram: Histogram,

table_write_stall_duration: Histogram,
table_write_encode_duration: Histogram,
table_write_wal_duration: Histogram,
table_write_memtable_duration: Histogram,
table_write_preprocess_duration: Histogram,
table_write_space_flush_wait_duration: Histogram,
table_write_instance_flush_wait_duration: Histogram,
table_write_flush_wait_duration: Histogram,
table_write_total_duration: Histogram,
}

impl Default for Metrics {
Expand All @@ -148,6 +159,24 @@ impl Default for Metrics {
.with_label_values(&["input"]),
compaction_output_sst_row_num_histogram: TABLE_COMPACTION_SST_ROW_NUM_HISTOGRAM
.with_label_values(&["output"]),

table_write_stall_duration: TABLE_WRITE_DURATION_HISTOGRAM
.with_label_values(&["stall"]),
table_write_encode_duration: TABLE_WRITE_DURATION_HISTOGRAM
.with_label_values(&["encode"]),
table_write_wal_duration: TABLE_WRITE_DURATION_HISTOGRAM.with_label_values(&["wal"]),
table_write_memtable_duration: TABLE_WRITE_DURATION_HISTOGRAM
.with_label_values(&["memtable"]),
table_write_preprocess_duration: TABLE_WRITE_DURATION_HISTOGRAM
.with_label_values(&["preprocess"]),
table_write_space_flush_wait_duration: TABLE_WRITE_DURATION_HISTOGRAM
.with_label_values(&["wait_space_flush"]),
table_write_instance_flush_wait_duration: TABLE_WRITE_DURATION_HISTOGRAM
.with_label_values(&["wait_instance_flush"]),
table_write_flush_wait_duration: TABLE_WRITE_DURATION_HISTOGRAM
.with_label_values(&["wait_flush"]),
table_write_total_duration: TABLE_WRITE_DURATION_HISTOGRAM
.with_label_values(&["total"]),
}
}
}
Expand All @@ -165,7 +194,7 @@ impl Metrics {

#[inline]
pub fn on_write_request_done(&self, num_rows: usize) {
TABLE_WRITE_BATCH_HISTGRAM.observe(num_rows as f64);
TABLE_WRITE_BATCH_HISTOGRAM.observe(num_rows as f64);
}

#[inline]
Expand All @@ -176,7 +205,48 @@ impl Metrics {

#[inline]
pub fn on_write_stall(&self, duration: Duration) {
TABLE_WRITE_STALL_DURATION_HISTOGRAM.observe(duration.as_secs_f64());
self.table_write_stall_duration
.observe(duration.as_secs_f64());
}

#[inline]
pub fn start_table_write_timer(&self) -> HistogramTimer {
self.table_write_total_duration.start_timer()
}

#[inline]
pub fn start_table_write_encode_timer(&self) -> HistogramTimer {
self.table_write_encode_duration.start_timer()
}

#[inline]
pub fn start_table_write_memtable_timer(&self) -> HistogramTimer {
self.table_write_memtable_duration.start_timer()
}

#[inline]
pub fn start_table_write_wal_timer(&self) -> HistogramTimer {
self.table_write_wal_duration.start_timer()
}

#[inline]
pub fn start_table_write_preprocess_timer(&self) -> HistogramTimer {
self.table_write_preprocess_duration.start_timer()
}

#[inline]
pub fn start_table_write_space_flush_wait_timer(&self) -> HistogramTimer {
self.table_write_space_flush_wait_duration.start_timer()
}

#[inline]
pub fn start_table_write_instance_flush_wait_timer(&self) -> HistogramTimer {
self.table_write_instance_flush_wait_duration.start_timer()
}

#[inline]
pub fn start_table_write_flush_wait_timer(&self) -> HistogramTimer {
self.table_write_flush_wait_duration.start_timer()
}

#[inline]
Expand Down