feat: only collecting all tables on demand in influxql planner #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
force-pushed
the
enhance-all-tables-getting-of-influxql
branch
from
164d9c5
to
cc0872a
Compare
jiacai2050
reviewed
Apr 24, 2023
Rachelint
force-pushed
the
enhance-all-tables-getting-of-influxql
branch
from
6c08d7d
to
4ce7193
Compare
Rachelint
force-pushed
the
enhance-all-tables-getting-of-influxql
branch
from
4f954cb
to
48e5ed0
Compare
jiacai2050
reviewed
Apr 24, 2023
Rachelint
force-pushed
the
enhance-all-tables-getting-of-influxql
branch
from
a88ccc1
to
b6dce20
Compare
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
…e#854) * add `all_tables` interface in `MetaProvider`. * make all tables will only be collected while calling table names of `SchemaProvider` of influxql. * remove some useless comments and params. * fix style and refactor some error descriptions. * add the custom impl for `table_exists` method in influxql SchemaProvider. * return error when schema/catalog not exist in `all_table` of `MetaProvider`. * add comments of `all_tables` in `MetaProvider`. * add comment for influxql planner and remove useless Result wrapping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Part of #830
Rationale for this change
Now, we collect and keep all tables in influxql planner even though it is unused.
It is wasteful to do this. So in this pr, I make it just do such works on demand.
What changes are included in this PR?
all_tablesmethod inMetaProvider.MetaProvider::all_tablesto get tables while they are actually needed(such as while influxql'sSchemaProvider::table_namesis called).Are there any user-facing changes?
None.
How does this change test
Test by ut.