Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl forwarding prom write #878

Merged
merged 2 commits into from
May 10, 2023
Merged

feat: impl forwarding prom write #878

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1e9902
feat: impl forward prom write
chunshao90 May 9, 2023
344a023
refactor by CR
chunshao90 May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 24 additions & 46 deletions proxy/src/http/prom.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ use std::{
use async_trait::async_trait;
use catalog::consts::DEFAULT_CATALOG;
use ceresdbproto::storage::{
value, Field, FieldGroup, PrometheusRemoteQueryRequest, PrometheusRemoteQueryResponse, Tag,
Value, WriteSeriesEntry, WriteTableRequest,
value, Field, FieldGroup, PrometheusRemoteQueryRequest, PrometheusRemoteQueryResponse,
RequestContext as GrpcRequestContext, Tag, Value, WriteRequest as GrpcWriteRequest,
WriteSeriesEntry, WriteTableRequest,
};
use common_types::{
datum::DatumKind,
Expand Down Expand Up @@ -43,59 +44,36 @@ use crate::{
error::{build_ok_header, ErrNoCause, ErrWithCause, Error, Internal, InternalNoCause, Result},
execute_plan,
forward::ForwardResult,
grpc::write::{execute_insert_plan, WriteContext},
Proxy,
Context as ProxyContext, Proxy,
};

impl reject::Reject for Error {}

impl<Q: QueryExecutor + 'static> Proxy<Q> {
/// Handle write samples to remote storage with remote storage protocol.
async fn handle_prom_write(&self, ctx: RequestContext, req: WriteRequest) -> Result<()> {
chunshao90 marked this conversation as resolved.
Show resolved Hide resolved
let request_id = RequestId::next_id();
let deadline = ctx.timeout.map(|t| Instant::now() + t);
let catalog = &ctx.catalog;
self.instance.catalog_manager.default_catalog_name();
let schema = &ctx.schema;
let schema_config = self
.schema_config_provider
.schema_config(schema)
.box_err()
.context(Internal {
msg: "Failed to get schema",
})?;
let write_context =
WriteContext::new(request_id, deadline, catalog.clone(), schema.clone());
let plans = self
.write_request_to_insert_plan(convert_write_request(req)?, schema_config, write_context)
.await
.box_err()
.context(Internal {
msg: "Failed to write via gRPC",
})?;

let mut success = 0;
for insert_plan in plans {
success += execute_insert_plan(
request_id,
catalog,
schema,
self.instance.clone(),
insert_plan,
deadline,
)
.await
.box_err()
.context(Internal {
msg: "Failed to write via gRPC",
})?;
let write_table_requests = convert_write_request(req)?;
let table_request = GrpcWriteRequest {
context: Some(GrpcRequestContext {
database: ctx.schema.clone(),
}),
table_requests: write_table_requests,
};
let ctx = ProxyContext {
runtime: self.engine_runtimes.write_runtime.clone(),
timeout: ctx.timeout,
};
let result = self.handle_write(ctx, table_request).await;
chunshao90 marked this conversation as resolved.
Show resolved Hide resolved
if let Some(header) = result.header {
if header.code != StatusCode::OK.as_u16() as u32 {
ErrNoCause {
code: StatusCode::INTERNAL_SERVER_ERROR,
msg: format!("fail to write storage, err:{:?}", header.error),
}
.fail()?;
}
}

debug!(
"Remote write finished, catalog:{}, schema:{}, success:{}",
catalog, schema, success
);

Ok(())
}

Expand Down