Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure pick at least 2 files for compaction #915

Merged
merged 3 commits into from
May 24, 2023
Merged

fix: ensure pick at least 2 files for compaction #915

merged 3 commits into from
May 24, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented May 23, 2023 •
edited
Loading

Related Issues

Closes #

Detailed Changes

  • Compact schedule interval change to 30s
  • Compact memory estimate change to sst size

Test Plan

New UT test_time_window_newest_bucket

@jiacai2050 jiacai2050 marked this pull request as ready for review May 23, 2023 07:33
@jiacai2050 jiacai2050 changed the title fix: ensure at least pick 2 files for compaction fix: ensure pick at least 2 files for compaction May 23, 2023
Rachelint
Rachelint approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit 01f7e6e into apache:main May 24, 2023
@jiacai2050 jiacai2050 deleted the fix-sst-number branch May 24, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rachelint Rachelint Rachelint approved these changes

@ShiKaiWi ShiKaiWi Awaiting requested review from ShiKaiWi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiacai2050 @Rachelint