refactor: open shard impl of TableEngine
#954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
force-pushed
the
support-shard-based-wal-data-recovery
branch
6 times, most recently
from
574eac5
to
a9aec64
Compare
ShiKaiWi
reviewed
Jun 1, 2023
ShiKaiWi
changed the title
TableEngineTableEngine
Rachelint
force-pushed
the
support-shard-based-wal-data-recovery
branch
from
e5c088a
to
30ea7a3
Compare
…`ShardOpener` in shard opening.
Rachelint
force-pushed
the
support-shard-based-wal-data-recovery
branch
from
30ea7a3
to
3661ef2
Compare
Rachelint
force-pushed
the
support-shard-based-wal-data-recovery
branch
from
3661ef2
to
6141b06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #
Detailed Changes
ShardOpenerto manage shard's opening.TableOperator,Instacne,ShardOpenerare like:TableOperator: install the successfully opened tables to their schemas, print error log for the faileds.Instance: insert the successfully opened tables to their spaces, and the faileds to spaces' failed maps.ShardOpener: do the tables(on same shard) opening work.Test Plan
Test by exist tests.