-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support region based wal replay #976
Merged
jiacai2050
merged 15 commits into
apache:main
from
Rachelint:support-shard-based-wal-replay
Jun 15, 2023
Merged
feat: support region based wal replay #976
jiacai2050
merged 15 commits into
apache:main
from
Rachelint:support-shard-based-wal-replay
Jun 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
changed the title
feat: support shard based wal replay
feat: support region based wal replay
Jun 7, 2023
Rachelint
force-pushed
the
support-shard-based-wal-replay
branch
2 times, most recently
from
June 8, 2023 08:11
f2b8317
to
c98d3fc
Compare
Rachelint
force-pushed
the
support-shard-based-wal-replay
branch
from
June 12, 2023 07:14
c98d3fc
to
71ce4f9
Compare
Rachelint
force-pushed
the
support-shard-based-wal-replay
branch
from
June 12, 2023 07:15
71ce4f9
to
182c49d
Compare
chunshao90
reviewed
Jun 13, 2023
jiacai2050
reviewed
Jun 13, 2023
Rachelint
force-pushed
the
support-shard-based-wal-replay
branch
3 times, most recently
from
June 15, 2023 05:49
669e802
to
0283b15
Compare
Rachelint
force-pushed
the
support-shard-based-wal-replay
branch
from
June 15, 2023 05:50
0283b15
to
c8775b2
Compare
Rachelint
force-pushed
the
support-shard-based-wal-replay
branch
from
June 15, 2023 06:34
450a79e
to
eafbd5b
Compare
jiacai2050
reviewed
Jun 15, 2023
jiacai2050
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dust1
pushed a commit
to dust1/ceresdb
that referenced
this pull request
Aug 9, 2023
## Rationale Part of apache#799 ## Detailed Changes - Define `WalReplayer` to carry out replay work. - Support both `TableBased`(original) and `RegionBased` replay mode in `WalReplayer`. - Expose related configs. ## Test Plan - Modify exist unit tests to cover the `RegionBased` wal replay. - Refactor the integration test to cover recovery logic(TODO).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Part of #799
Detailed Changes
WalReplayer
to carry out replay work.TableBased
(original) andRegionBased
replay mode inWalReplayer
.Test Plan
RegionBased
wal replay.