Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support region based wal replay #976

Merged
merged 15 commits into from
Jun 15, 2023

Conversation

Rachelint
Copy link
Contributor

@Rachelint Rachelint commented Jun 7, 2023

Rationale

Part of #799

Detailed Changes

  • Define WalReplayer to carry out replay work.
  • Support both TableBased(original) and RegionBased replay mode in WalReplayer.
  • Expose related configs.

Test Plan

  • Modify exist unit tests to cover the RegionBased wal replay.
  • Refactor the integration test to cover recovery logic(TODO).

@Rachelint Rachelint marked this pull request as ready for review June 7, 2023 16:36
@Rachelint Rachelint mentioned this pull request Jun 7, 2023
12 tasks
@Rachelint Rachelint changed the title feat: support shard based wal replay feat: support region based wal replay Jun 7, 2023
@Rachelint Rachelint force-pushed the support-shard-based-wal-replay branch 2 times, most recently from f2b8317 to c98d3fc Compare June 8, 2023 08:11
@jiacai2050 jiacai2050 self-requested a review June 9, 2023 05:54
@Rachelint Rachelint force-pushed the support-shard-based-wal-replay branch from c98d3fc to 71ce4f9 Compare June 12, 2023 07:14
@Rachelint Rachelint force-pushed the support-shard-based-wal-replay branch from 71ce4f9 to 182c49d Compare June 12, 2023 07:15
analytic_engine/src/instance/flush_compaction.rs Outdated Show resolved Hide resolved
analytic_engine/src/instance/open.rs Outdated Show resolved Hide resolved
analytic_engine/src/instance/wal_replayer.rs Outdated Show resolved Hide resolved
@Rachelint Rachelint force-pushed the support-shard-based-wal-replay branch 3 times, most recently from 669e802 to 0283b15 Compare June 15, 2023 05:49
@Rachelint Rachelint force-pushed the support-shard-based-wal-replay branch from 0283b15 to c8775b2 Compare June 15, 2023 05:50
@Rachelint Rachelint force-pushed the support-shard-based-wal-replay branch from 450a79e to eafbd5b Compare June 15, 2023 06:34
analytic_engine/src/instance/flush_compaction.rs Outdated Show resolved Hide resolved
analytic_engine/src/instance/open.rs Outdated Show resolved Hide resolved
analytic_engine/src/instance/open.rs Outdated Show resolved Hide resolved
analytic_engine/src/instance/wal_replayer.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 1fd17f3 into apache:main Jun 15, 2023
dust1 pushed a commit to dust1/ceresdb that referenced this pull request Aug 9, 2023
## Rationale
Part of apache#799 

## Detailed Changes
- Define `WalReplayer` to carry out replay work.
- Support both `TableBased`(original) and `RegionBased` replay mode in
`WalReplayer`.
- Expose related configs.

## Test Plan
- Modify exist unit tests to cover the `RegionBased` wal replay.
- Refactor the integration test to cover recovery logic(TODO).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants