### Macro to Simplify Array Length Calculation (Revived from PR #401) #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks better - thanks for redoing it - but it should be AP_ARRAY_LEN() rather than just ARRAY_LEN() to avoid namespace conflicts. Hopefully you can change it with a sed command :) |
This commit introduces the AP_ARRAY_LEN macro to simplify array length calculations by replacing occurrences of `sizeof(a)/sizeof(a[0])` with `AP_ARRAY_LEN(a)`.
arturobernalg
force-pushed
the
ARRAY_LEN-macro
branch
from
4206487 to
6631444
Compare
Agreed. I've implemented the changes and updated the committee message. |
|
Also thanks from my side! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on PR #401, which proposed
adding the
ARRAY_LENmacro to improve code readability and maintainability. The originalPR was abandoned and had conflicts, so I have rebased it, resolved issues, and integrated
the changes.