-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[MINOR] Fix logical type issue for timestamp columns #17601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: branch-0.x
Are you sure you want to change the base?
[MINOR] Fix logical type issue for timestamp columns #17601
Conversation
…4161) Co-authored-by: Jonathan Vexler <=> Co-authored-by: sivabalan <n.siva.b@gmail.com> Co-authored-by: Vamsi <vamsi@onehouse.ai> Co-authored-by: Y Ethan Guo <ethan.guoyihua@gmail.com> Co-authored-by: Lin Liu <linliu.code@gmail.com>
ac2916a to
5ef5773
Compare
408cc29 to
0c4e026
Compare
0c4e026 to
79c4a88
Compare
87efa59 to
4440884
Compare
4440884 to
996a1ed
Compare
7595450 to
e44e6d2
Compare
|
@linliu-code We can add support for Spark 3.2 as well in this PR if it is not very difficult. The fix should ideally work for Spark 3.2 as well. |
6973034 to
103e3b4
Compare
103e3b4 to
e35e8f9
Compare
CI report:
Bot commands@hudi-bot supports the following commands:
|
Change Logs
This pr #9743 adds more schema evolution functionality and schema processing. However, we used the InternalSchema system to do various operations such as fix null ordering, reorder, and add columns. At the time, InternalSchema only had a single Timestamp type. When converting back to avro, this was assumed to be micros. Therefore, if the schema provider had any millis columns, the processed schema would end up with those columns as micros.
In this pr to update column stats with better support for logical types: #13711, the schema issues were fixed, as well as additional issues with handling and conversion of timestamps during ingestion.
this pr aims to add functionality to spark and hive readers and writers to automatically repair affected tables.
After switching to use the 1.1 binary, the affected columns will undergo evolution from timestamp-micros to timestamp-mills. Normally a lossy evolution that is not supported, this evolution is ok because the data is actually still timestamp-millis it is just mislabeled as micros in the parquet and table schemas
Impact
When reading from a hudi table using spark or hive reader if the table schema has a column as millis, but the data schema is micros, we will assume that this column is affected and read it as a millis value instead of a micros value. This correction is also applied to all readers that the default write paths use. As a table is rewritten the parquet files will be correct. A table's latest snapshot can be immediately fixed by writing one commit with the 1.1 binary, and then clustering the entire table.
Risk level (write none, low medium or high below)
High,
extensive testing was done and functional tests were added.
Documentation Update
#14100
Contributor's checklist