[HUDI-6941] Fix partition pruning for multiple partition fields #9863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codope
commented
Oct 14, 2023
| } | ||
| } | ||
|
|
||
| @Disabled("HUDI-6320") |
Member
Author
There was a problem hiding this comment.
This test will be useful when HUDI-6320 is fixed properly.
codope
commented
Oct 14, 2023
| || classOf[TimestampBasedAvroKeyGenerator].getName.equalsIgnoreCase(keyGeneratorClassName) | ||
| || classOf[CustomKeyGenerator].getName.equalsIgnoreCase(keyGeneratorClassName) | ||
| || classOf[CustomAvroKeyGenerator].getName.equalsIgnoreCase(keyGeneratorClassName)) { | ||
| || classOf[TimestampBasedAvroKeyGenerator].getName.equalsIgnoreCase(keyGeneratorClassName)) { |
This was referenced Oct 14, 2023
danny0405
approved these changes
Oct 14, 2023
Contributor
danny0405
left a comment
danny0405
left a comment
There was a problem hiding this comment.
+1, thanks for taking care.
xuzifu666
approved these changes
Oct 14, 2023
| if (listingModeOverride != null) { | ||
| properties.setProperty(DataSourceReadOptions.FILE_INDEX_LISTING_MODE_OVERRIDE.key, listingModeOverride) | ||
| } | ||
| val partitionColumns = metaClient.getTableConfig.getPartitionFields |
Member
There was a problem hiding this comment.
nice，and in our condition only merge this code would work well #9862 then we would have more test for it
Collaborator
Contributor
|
After apply this patch, some cases would mistaken choose broadcast hash join even for big table. In those cases, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Reverts 2d779fb and fixes #9858
Impact
Fixes partition pruning and improves performance for a table with multiple partition fields.
After the fix, only 1 partition is listed as in the screenshot below.
Risk level (write none, low medium or high below)
none
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist