Skip to content

Commit

Permalink
Comments, thanks Ryan!
Browse files Browse the repository at this point in the history
  • Loading branch information
Fokko committed Oct 6, 2023
1 parent caa8a31 commit 9b4efa1
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pyiceberg/io/pyarrow.py
Original file line number Diff line number Diff line change
Expand Up @@ -1103,7 +1103,7 @@ def _primitive_to_phyisical(iceberg_type: PrimitiveType) -> str:
return visit(iceberg_type, _PRIMITIVE_TO_PHYISCAL_TYPE_VISITOR)


class PrimitiveToPyhsicalType(SchemaVisitorPerPrimitiveType[str]):
class PrimitiveToPhysicalType(SchemaVisitorPerPrimitiveType[str]):
def schema(self, schema: Schema, struct_result: str) -> str:
raise ValueError(f"Expected primitive-type, got: {schema}")

Expand All @@ -1123,7 +1123,7 @@ def visit_fixed(self, fixed_type: FixedType) -> str:
return "BYTE_ARRAY"

def visit_decimal(self, decimal_type: DecimalType) -> str:
raise ValueError("unknown")
raise "FIXED_LEN_BYTE_ARRAY"

def visit_boolean(self, boolean_type: BooleanType) -> str:
return "BOOLEAN"
Expand Down Expand Up @@ -1162,7 +1162,7 @@ def visit_binary(self, binary_type: BinaryType) -> str:
return "BYTE_ARRAY"


_PRIMITIVE_TO_PHYISCAL_TYPE_VISITOR = PrimitiveToPyhsicalType()
_PRIMITIVE_TO_PHYISCAL_TYPE_VISITOR = PrimitiveToPhysicalType()


class StatsAggregator:
Expand Down

0 comments on commit 9b4efa1

Please sign in to comment.