Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: The current snapshot with id 0 will be skip. #232

Closed
ZENOTME opened this issue Dec 21, 2023 · 2 comments · Fixed by #249
Closed

bug: The current snapshot with id 0 will be skip. #232

ZENOTME opened this issue Dec 21, 2023 · 2 comments · Fixed by #249
Assignees
@MehulBatra
Milestone
PyIceberg 0.6.0 r...

Comments

@ZENOTME
Copy link
Contributor

ZENOTME commented Dec 21, 2023 •
edited
Loading

I find that the current snapshot with id 0 will be ignored. It caused by following if statement:

iceberg-python/pyiceberg/table/__init__.py

Line 812 in cf31507

if snapshot_id := self.metadata.current_snapshot_id:

In this if statement, the 0 and None both be skipped.
@Fokko
Copy link
Contributor

Fokko commented Dec 21, 2023

That's indeed a bug, thanks for spotting this @ZENOTME. Are you interested in creating a PR to fix it?

@Fokko Fokko added this to the PyIceberg 0.6.0 release milestone Dec 28, 2023
@MehulBatra
Copy link
Contributor

I will take care of it.

@MehulBatra MehulBatra mentioned this issue Jan 3, 2024
Merged
@Fokko Fokko closed this as completed in #249 Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MehulBatra MehulBatra

Labels
None yet
Projects
None yet
Milestone
PyIceberg 0.6.0 release
Development

Successfully merging a pull request may close this issue.

falsy value of zero MehulBatra/iceberg-python
3 participants
@Fokko @ZENOTME @MehulBatra