falsy value of zero

[MehulBatra]

Resolves: 232

Python, certain values are considered False in a boolean context. These include None, 0, empty sequences/collections ('', [], {}), and others. This is often referred to as “falsy” values.

With the current implementation of ->

def current_snapshot(self) -> Optional[Snapshot]
      if snapshot_id := self.metadata.current_snapshot_id:
      

The walrus operator in the if condition will assign a value to snapshot_id, but it will marked as false in case of zero and None hence will skip snapshot_id = 0 as well, to solve this raise this PR

[MehulBatra]

Tested Locally all three seems to be passing

class DummyClass:
    def __init__(self, metadata):
        self.metadata = metadata

def test_snapshot_id_condition():
    import unittest

    class TestMyClass(unittest.TestCase):
        def test_snapshot_id_truthy(self):
            instance = DummyClass(metadata={'current_snapshot_id': 42})
            self.assertTrue((snapshot_id := instance.metadata.get('current_snapshot_id')) is not None or isinstance(snapshot_id, int))

        def test_snapshot_id_falsy(self):
            instance = DummyClass(metadata={'current_snapshot_id': None})
            self.assertFalse((snapshot_id := instance.metadata.get('current_snapshot_id')) is not None or isinstance(snapshot_id, int))

        def test_snapshot_id_zero(self):
            instance = DummyClass(metadata={'current_snapshot_id': 0})
            self.assertTrue((snapshot_id := instance.metadata.get('current_snapshot_id')) is not None or isinstance(snapshot_id, int))

    return unittest.TestLoader().loadTestsFromTestCase(TestMyClass)


if __name__ == '__main__':
    unittest.TextTestRunner().run(test_snapshot_id_condition())

[Fokko]

Thanks @MehulBatra for working on this!