Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

falsy value of zero #249

Merged
merged 2 commits into from
Jan 4, 2024
Merged

falsy value of zero #249

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f060e3d
certain values are considered False in a boolean context. These inclu…
MehulBatra Jan 3, 2024
e7e483f
Update pyiceberg/table/__init__.py
MehulBatra Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyiceberg/table/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,8 +545,8 @@ def new_snapshot_id(self) -> int:

def current_snapshot(self) -> Optional[Snapshot]:
"""Get the current snapshot for this table, or None if there is no current snapshot."""
if snapshot_id := self.metadata.current_snapshot_id:
return self.snapshot_by_id(snapshot_id)
if self.metadata.current_snapshot_id is not None:
return self.snapshot_by_id(self.metadata.current_snapshot_id)
return None

def snapshot_by_id(self, snapshot_id: int) -> Optional[Snapshot]:
Expand Down