Skip to content

fix: improve makefile #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 26, 2024
Merged

fix: improve makefile #1091

merged 3 commits into from
Aug 26, 2024

Conversation

@TiansuYu
Copy link
Contributor

@TiansuYu TiansuYu commented Aug 22, 2024

  • Added a help command to display all commands having ## comments
  • Improved how poetry being installed
    • (Personally, i have this installed via pipx, still pip install user wide tool should have --user added)

@TiansuYu TiansuYu marked this pull request as ready for review August 22, 2024 16:28
@TiansuYu
Copy link
Contributor Author

TiansuYu commented Aug 23, 2024

@sungwy Could you have a look?

sungwy
sungwy reviewed Aug 24, 2024
View reviewed changes
Copy link
Collaborator

@sungwy sungwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TiansuYu - this looks great! I tried out your help command and I'm really liking it.

And the --user change makes sense as well.

I left some nits to improve the formatting of the help command output

@TiansuYu @sungwy
Apply suggestions from code review
742f080 
Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com>
@TiansuYu TiansuYu requested a review from sungwy August 24, 2024 09:26
@sungwy sungwy merged commit 87d52d3 into apache:main Aug 26, 2024
sungwy added a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
@TiansuYu @sungwy
fix: improve makefile (apache#1091)
09801a2 
* fix: improve makefile

* fix: pin poetry version

* Apply suggestions from code review

Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com>

---------

Co-authored-by: Tiansu Yu <tiansu.yu@icloud>
Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com>
sungwy added a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
@TiansuYu @sungwy
fix: improve makefile (apache#1091)
ea08c6c 
* fix: improve makefile

* fix: pin poetry version

* Apply suggestions from code review

Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com>

---------

Co-authored-by: Tiansu Yu <tiansu.yu@icloud>
Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sungwy sungwy sungwy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TiansuYu @sungwy