Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow leading underscore in column name used in row filter #1358

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Allow leading underscore in column name used in row filter #1358

merged 5 commits into from
Nov 22, 2024

Conversation

vincenzon
Copy link
Contributor

@vincenzon vincenzon commented Nov 21, 2024 •
edited by Fokko
Loading

Fixes #1357

@vincenzon
Update parser.py
415590d 
Allow leading underscore in column name used in row filter.
@vincenzon
Merge pull request #1 from vincenzon/vincenzon-patch-1
71dd82f 
Update parser.py
@Fokko
Copy link
Contributor

Fokko commented Nov 21, 2024

@vincenzon Thanks for fixing this. Should we add a test to ensure that we don't break this in the future? :)

@vincenzon
Copy link
Contributor Author

I added a test. I didn't change the quote character to backtick though I think it should be done. Let me know if you'd like that change in this PR or a separate one or something else.

Fokko
Fokko approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vincenzon I think this is fine, thanks for fixing this 👍

@Fokko Fokko merged commit d86ab6e into apache:main Nov 22, 2024
7 checks passed
kevinjqliu pushed a commit to kevinjqliu/iceberg-python that referenced this pull request Nov 25, 2024
@vincenzon @kevinjqliu
Allow leading underscore in column name used in row filter (apache#1358)
ce97600 
* Update parser.py

Allow leading underscore in column name used in row filter.

* Update test_parser.py

* Update test_parser.py

* Update test_parser.py
@kevinjqliu kevinjqliu mentioned this pull request Nov 25, 2024
Merged
@kevinjqliu kevinjqliu added this to the PyIceberg 0.8.1 release milestone Nov 26, 2024
kevinjqliu added a commit that referenced this pull request Nov 27, 2024
@kevinjqliu @sumanth-manchala
@gitzwz @vincenzon @bigluck @binayakd @Fokko
[release] Pyiceberg 0.8.1 (#1369)
d24e0c9 
* use the non-deprecated func (#1326)

* 0.8.0 post release steps (#1334)

* add

* fix mkdoc

* Drop upper bounds for fsspec and it's implementations (#1341)

* Drop upper bounds for fsspec and it's implementations

* Run poetry lock

* Ignore tables without `table_type` from Glue and Hive

* Ignore tables without table_type parameters while loading all iceberg table from Glue and Hive catalog (#1331)

* Use TABLE_TYPE

---------

Co-authored-by: Wenzhuo Zhao <zhaowenzhuo01@bilibili.com>

* Replace reference of `Table.identifier` with `Table.name` (#1346)

* fix Table.name

* replace Table.identifier with Table.name

* add warning filter

* Allow leading underscore in column name used in row filter (#1358)

* Update parser.py

Allow leading underscore in column name used in row filter.

* Update test_parser.py

* Update test_parser.py

* Update test_parser.py

* Remove Python 3.13 upper bound restriction (#1355)

* Remove Python 3.13 upper bound restriction

* Fix missing poetry.lock file

* Upgrading numpy on the poetry.lock file from v1.26.0 to v1.26.4

* Improve documentation for "how to release" (#1359)

* initial update

* edits

* add gpg instructions

* verify artifacts

* add twine not

* grammar

* edits

* remove old artifacts

* update doc workflow action

* and name

* add docs on patch vs major/minor release

* fix `KeyError` raised by `add_files` when parquet file doe not have column stats (#1354)

* fix KeyError, by switching del to pop

* added unit test

* update test

* fix python 3.9 compatibility, and refactor test

* update test

* bump to 0.8.1

* Add instruction for patch release (#1373)

* add instruction for patch release

* create branch from tag

* Write `null` when there is no parent-snapshot-id (#1383)

---------

Co-authored-by: Sumanth <33193748+sumanth-manchala@users.noreply.github.com>
Co-authored-by: gitzwz <72312233+gitzwz@users.noreply.github.com>
Co-authored-by: Wenzhuo Zhao <zhaowenzhuo01@bilibili.com>
Co-authored-by: vincenzon <mvcalder@gmail.com>
Co-authored-by: Luca Bigon <luca.bigon@bauplanlabs.com>
Co-authored-by: Binayak Dasgupta <binayakd86@gmail.com>
Co-authored-by: Fokko Driesprong <fokko@apache.org>
kevinjqliu pushed a commit to kevinjqliu/iceberg-python that referenced this pull request Nov 27, 2024
@vincenzon @kevinjqliu
Allow leading underscore in column name used in row filter (apache#1358)
fd29ec1 
* Update parser.py

Allow leading underscore in column name used in row filter.

* Update test_parser.py

* Update test_parser.py

* Update test_parser.py
@kevinjqliu kevinjqliu mentioned this pull request Nov 27, 2024
Merged
kevinjqliu pushed a commit that referenced this pull request Nov 27, 2024
@vincenzon @kevinjqliu
Allow leading underscore in column name used in row filter (#1358)
f3323ab 
* Update parser.py

Allow leading underscore in column name used in row filter.

* Update test_parser.py

* Update test_parser.py

* Update test_parser.py
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
@vincenzon @sungwy
Allow leading underscore in column name used in row filter (apache#1358)
534b255 
* Update parser.py

Allow leading underscore in column name used in row filter.

* Update test_parser.py

* Update test_parser.py

* Update test_parser.py
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
@vincenzon @sungwy
Allow leading underscore in column name used in row filter (apache#1358)
de11a79 
* Update parser.py

Allow leading underscore in column name used in row filter.

* Update test_parser.py

* Update test_parser.py

* Update test_parser.py
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 24, 2024
@vincenzon @sungwy
Allow leading underscore in column name used in row filter (apache#1358)
12effb6 
* Update parser.py

Allow leading underscore in column name used in row filter.

* Update test_parser.py

* Update test_parser.py

* Update test_parser.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fokko Fokko Fokko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PyIceberg 0.8.1 release
Development

Successfully merging this pull request may close these issues.

Row filter parse exception on column starting with underscore
3 participants
@vincenzon @Fokko @kevinjqliu