Update upload-artifact to use v4

[kevinjqliu]

Both actions/upload-artifact@v3 and actions/download-artifact@v3 are deprecated and requires update, based on https://lists.apache.org/thread/nx19j3h61tjmsk8c8vx24gbq6ygf7pyf

upload-artifact@v3 only used in iceberg-python
https://grep.app/search?q=actions/upload-artifact%40v3&filter[repo.pattern][0]=apache/iceberg

download-artifact@v3 is not used in any iceberg-related repos
https://grep.app/search?q=actions/download-artifact&filter[repo.pattern][0]=apache/iceberg

Migrate from V3 to V4 following the migration guide to merge multiple artifacts into one with @actions/upload-artifact/merge.

Removed macos-12 from the os matrix since its deprecated and added macos-15 which is currently in public preview.

Testing "Python Release" action

• main branch https://github.com/kevinjqliu/iceberg-python/actions/runs/12036359688
• feature branch https://github.com/kevinjqliu/iceberg-python/actions/runs/12035706304

Downloaded artifacts and verified that they have the same file names, but different hash.

[Fokko]

Thanks for bumping this, unfortunately, we've downgraded to v3 a while ago #396 for a specific reason.

With V4 it does not combine the zip files, so we get 5 zip files that we need to unpack, and then combine again. With #1370 this would explode to 25 zips. While releasing iceberg-go I noticed that they use a very fancy script that gets the relevant information of the release PR through the GitHub API. This removes quite a few steps and might be a good idea to introduce here when we're going to v4.

[Fokko]

Ohh, this is nice! https://github.com/actions/upload-artifact/blob/main/merge/README.md

[kevinjqliu]

removed macos-12 because its deprecated and causing the merge step to not run

https://github.com/kevinjqliu/iceberg-python/actions/runs/12018552791

[Fokko]

Good catch, I noticed that macos-15 is also available. Maybe we can add that one as well. I checked it on my local branch, and it works over there: https://github.com/Fokko/iceberg-python/actions/runs/12033072248

[kevinjqliu]

@Fokko I double-checked the new artifacts, file names match but they have different hashes.

[Fokko]

@kevinjqliu Can you elaborate? I just pushed it to my own branch, and I see identical hashes:

➜  Downloads shasum -a 512 release-ubuntu-22.04/pyiceberg-0.8.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl 
097dc7cc8cf214b3489e3c8facf66e08212570ca5f5d0cf16df88cd5b7839e76a2807e1326d80716ddb46bbbe4cdd423599ff3db0265cfd56c79ebe56678e39a  release-ubuntu-22.04/pyiceberg-0.8.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
➜  Downloads shasum -a 512 release-main/pyiceberg-0.8.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
097dc7cc8cf214b3489e3c8facf66e08212570ca5f5d0cf16df88cd5b7839e76a2807e1326d80716ddb46bbbe4cdd423599ff3db0265cfd56c79ebe56678e39a  release-main/pyiceberg-0.8.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl

[kevinjqliu]

I was comparing between running the action on main versus this branch

Do you know a better way to verify this?

[Fokko]

@kevinjqliu Ah I see, I don't think that we have fully reproducible builds. For example, if a timestamp in some wheel is different, then it would yield another hash. I think it is a nice feature to have, but not strickly required for the ASF releases AFAIK.