Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletion Vectors read support #1516

Merged
merged 16 commits into from
Mar 26, 2025
Merged

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Jan 15, 2025

First see if we can produce some deletion vectors.

Resolves #1549

First see if we can produce some deletion vectors.
@kevinjqliu
Copy link
Contributor

Sidenote, we dont have a way to read puffin files in python. I saw this PR from iceberg-rust, apache/iceberg-rust#892
Perhaps this will be a good candidate for pyiceberg_core

@Fokko
Copy link
Contributor Author

Fokko commented Jan 17, 2025

I want to try using the Python roaringbitmap API first, otherwise, we can go the Iceberg-Rust route.

@kevinjqliu
Copy link
Contributor

Looks like V3 is not supported on the pyiceberg side

=========================== short test summary info ============================
FAILED tests/integration/test_reads.py::test_read_table_with_deletion_vector[session_catalog_hive] - pyiceberg.exceptions.ValidationError: 1 validation error for TableMetadataWrapper
  Input tag '3' found using 'format_version' | 'format-version' does not match any of the expected tags: 1, 2 [type=union_tag_invalid, input_value={'format-version': 3, 'ta...c474ec.metadata.json'}]}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.10/v/union_tag_invalid
FAILED tests/integration/test_reads.py::test_read_table_with_deletion_vector[session_catalog] - pydantic_core._pydantic_core.ValidationError: 1 validation error for TableResponse
metadata
  Input tag '3' found using 'format_version' | 'format-version' does not match any of the expected tags: 1, 2 [type=union_tag_invalid, input_value={'format-version': 3, 'ta...26ab8a.metadata.json'}]}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.10/v/union_tag_invalid
==== 2 failed, 970 passed, 8 skipped, 2757 deselected in 346.14s (0:05:46) =====
make: *** [Makefile:55: test-integration] Error 1
Error: Process completed with exit code 2.

@Fokko Fokko mentioned this pull request Jan 20, 2025
@Fokko
Copy link
Contributor Author

Fokko commented Jan 20, 2025

@kevinjqliu That's correct, I've split that out here: #1540

@Fokko
Copy link
Contributor Author

Fokko commented Jan 21, 2025

@kevinjqliu PR is out here: #1554 :)

@kevinjqliu
Copy link
Contributor

do we want to include this as part of 0.9.0? the ability to read puffin files would be great!

@Fokko
Copy link
Contributor Author

Fokko commented Feb 3, 2025

@kevinjqliu I agree, but I don't think there is a lot of value in just supporting Puffin without having the ability to actually understand the content of the Puffin files. For the CI we're blocked on Iceberg-Java 1.8.0, until then I don't think there is much value of getting this in

@Fokko Fokko marked this pull request as ready for review February 17, 2025 10:24
@Fokko Fokko changed the title WIP: Deletion vectors Deletion vectors Feb 17, 2025
@Fokko Fokko changed the title Deletion vectors Deletion Vectors read support Feb 17, 2025
@Fokko Fokko requested a review from kevinjqliu March 4, 2025 09:25
@Fokko Fokko added this to the PyIceberg 0.10.0 milestone Mar 4, 2025
Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Excited for puffin files

@Fokko Fokko mentioned this pull request Mar 20, 2025
12 tasks
@kevinjqliu kevinjqliu added the V3 label Mar 26, 2025
@kevinjqliu
Copy link
Contributor

except for the MAX_JAVA_SIGNED variable, everything else LGTM!

@Fokko Fokko merged commit 62191ee into apache:main Mar 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Deletion Vectors
2 participants