Table Requirements Validation #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HonahX
commented
Dec 11, 2023
| @@ -34,6 +34,10 @@ def __repr__(self) -> str: | |||
| """Return the string representation of the SnapshotRefType class.""" | |||
| return f"SnapshotRefType.{self.name}" | |||
|
|
|||
| def __str__(self) -> str: | |||
| """Return the string representation of the SnapshotRefType class.""" | |||
| return self.value | |||
There was a problem hiding this comment.
Seems we need this __str__. Otherwise,
>>> ref_type=SnapshotRefType.Branch
>>> f"Test: {ref_type}"will show Test: SnapshotRefType.Branch in my local environment (Python 3.11) but Test: branch in CI's python 3.8. I think it's because Python 3.11 changes the default behavior of Enum's str: https://blog.pecar.me/python-enum
Fokko
reviewed
Dec 11, 2023
|
|
||
| class AssertCreate(TableRequirement): | ||
| """The table must not already exist; used for create transactions.""" | ||
|
|
||
| type: Literal["assert-create"] = Field(default="assert-create") | ||
|
|
||
| def validate(self, base_metadata: Optional[TableMetadata]) -> None: |
There was a problem hiding this comment.
Should we update the signature of the parent class as well?
There was a problem hiding this comment.
Thanks for the suggestion! I updated the signature and also add None-checks for other requirements, which will raise exception when the current table metadata is None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the second part of #140
It implements a
validatemethod for each table requirement. This method raises aCommitFailedExceptionwith an appropriate error message if the table's metadata does not meet the requirements.