Moto server implementation for pytest #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @HonahX since he's the original author of the Glue catalog |
HonahX
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
LGTM! Thanks for the fix @sebpretzer! It is great that we can finally get rid of the _patch_aiobotocore and use PyarrowFileIO in the unit tests!
Fokko
changed the title
Fokko
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Thanks for working on this @sebpretzer 🙌 and thanks for the review @HonahX
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Jan 13, 2024
* adding moto server dependency * change test harness to moto server * fixing mypy issues * making glue data catalog a factory * reverting unnecessary moto server clients * reverting to simplest implementation of moto server with s3 only * clean up dynamodb variable overwrite * fixing failed test * dropping for default port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR relating to #222.
This should be a drop in replacement for
moto.mock_s3, by pointing the s3 clients at a moto server endpoint url.By doing this, you can:
aiobotocorepyiceberg.io.fsspec.FsspecFileIOover the default ofpyiceberg.io.pyarrow.PyArrowFileIO.Glue and DynamoDB still use the basic
mock_glueandmock_dynamodb. They could probably be moved over to the sever implementation as well, but it was taking more work than I wanted so I didn't include it.