Small getting started guide on writes #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
force-pushed
the
fd-getting-started
branch
from
6c7d6e3 to
683b700
Compare
HonahX
reviewed
Jan 28, 2024
mkdocs/docs/index.md
Outdated
|
|
||
| with table.update_schema() as update_schema: | ||
| # Blocked by https://github.com/apache/iceberg-python/pull/305 | ||
| update_schema.union_by_name(Catalog._convert_schema_if_needed(df.schema)) |
There was a problem hiding this comment.
Shall we use add_column instead?
update_schema.add_column("tip_per_mile", DoubleType())
I think it might be better not to use internal methods in the tutorial.
There was a problem hiding this comment.
I fully agree. I should have been more explicit in the comment above. Once #305 is in, we can update the union_by_name to also accept pa.Schema. WDYT?
There was a problem hiding this comment.
Thanks for the context! Yes, I think it's a good idea. Let's do it after #305 😄
There was a problem hiding this comment.
I should have marked it as a draft. It is ready now @HonahX :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to get people started!