Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Avro tests #552

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Fix the Avro tests #552

merged 1 commit into from
Mar 28, 2024

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Mar 27, 2024

When writing V1, the sequence-numbers should be None. For V2 they will be written and read into the original value.

When writing V1, the sequence-numbers should be None.
For V2 they will be written and read into the original value.
Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @Fokko!

@HonahX HonahX merged commit 35f6f33 into apache:main Mar 28, 2024
7 checks passed
@Fokko Fokko deleted the fd-fix-avro-tests branch March 28, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants