Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix column rename doc example to reflect correct API #59

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fix column rename doc example to reflect correct API #59

merged 1 commit into from
Oct 12, 2023

Conversation

cabhishek
Copy link
Contributor

  • Rename column example in this doc is incorrect.
  • This PR updates the example to use update.rename_column(...) instead of update.rename(...).

After PR

with table.update_schema() as update:
    update.rename_column("retries", "num_retries")
    # This will rename `confirmed_by` to `exchange`
    update.rename_column("properties.confirmed_by", "exchange")

@rdblue
Copy link
Contributor

rdblue commented Oct 11, 2023

Thanks, @cabhishek! I'll merge when tests are green.

Fokko
Fokko approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cabhishek for fixing this 🎉

@Fokko Fokko merged commit 0a584a4 into apache:main Oct 12, 2023
Fokko pushed a commit to Fokko/iceberg-python that referenced this pull request Oct 15, 2023
@cabhishek @Fokko
Fix column rename doc example to reflect correct API (apache#59)
cbd00e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdblue rdblue rdblue approved these changes

@Fokko Fokko Fokko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PyIceberg 0.5.1 release
Development

Successfully merging this pull request may close these issues.
3 participants
@cabhishek @rdblue @Fokko