Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require full expression parse match #88

Merged
merged 3 commits into from
Oct 21, 2023
Merged

Require full expression parse match #88

merged 3 commits into from
Oct 21, 2023

Conversation

danielcweeks
Copy link
Contributor

No description provided.

@danielcweeks danielcweeks requested review from rdblue and Fokko October 21, 2023 18:55
hussein-awala
hussein-awala approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I just tested it, and all the filters seem to be considered now.

Fokko
Fokko approved these changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion on the test, apart from that it looks like a good change to me

@danielcweeks @Fokko
Update tests/expressions/test_parser.py
748ce38 
Co-authored-by: Fokko Driesprong <fokko@apache.org>
@Fokko Fokko added this to the PyIceberg 0.5.1 release milestone Oct 21, 2023
@danielcweeks danielcweeks merged commit 877a574 into apache:main Oct 21, 2023
@danielcweeks danielcweeks deleted the fix/sql-parse branch October 21, 2023 20:39
Fokko added a commit that referenced this pull request Oct 24, 2023
@danielcweeks @Fokko
Require full expression parse match (#88)
2a3c1bd 
* Require full expression parse match

* Codestyle

* Update tests/expressions/test_parser.py

Co-authored-by: Fokko Driesprong <fokko@apache.org>

---------

Co-authored-by: Fokko Driesprong <fokko@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fokko Fokko Fokko approved these changes

@hussein-awala hussein-awala hussein-awala approved these changes

@rdblue rdblue Awaiting requested review from rdblue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PyIceberg 0.5.1 release
Development

Successfully merging this pull request may close these issues.
3 participants
@danielcweeks @Fokko @hussein-awala