Skip to content

chore(catalog/rest): Add response headers in error for debug #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xuanwo merged 2 commits into from
Mar 24, 2025
Merged

chore(catalog/rest): Add response headers in error for debug #1129

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dbcac9
chore(catalog/rest): Add response headers in error for debug
Xuanwo Mar 24, 2025
298d0e1
Merge branch 'main' into add-headers-in-error
Xuanwo Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/catalog/rest/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,11 +254,14 @@ pub(crate) async fn deserialize_catalog_response<R: DeserializeOwned>(
/// TODO: Eventually, this function should return an error response that is custom to the error
/// codes that all endpoints share (400, 404, etc.).
pub(crate) async fn deserialize_unexpected_catalog_error(response: Response) -> Error {
let (status, headers) = (response.status(), response.headers().clone());
let bytes = match response.bytes().await {
Ok(bytes) => bytes,
Err(err) => return err.into(),
};

Error::new(ErrorKind::Unexpected, "Received unexpected response")
.with_context("status", status.to_string())
.with_context("headers", format!("{:?}", headers))
.with_context("json", String::from_utf8_lossy(&bytes))
}
Loading