Skip to content

Add equality_ids to FileScanTaskDeleteFile #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025
Merged

Add equality_ids to FileScanTaskDeleteFile #1235

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7921281
feat: add equality_ids to FileScanTaskDeleteFile
sdd Apr 23, 2025
0ebc334
Merge branch 'main' into feat/add-eq-ids-to-file-scan-task-delete-file
liurenjie1024 Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crates/iceberg/src/scan/task.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ impl From<&DeleteFileContext> for FileScanTaskDeleteFile {
file_path: ctx.manifest_entry.file_path().to_string(),
file_type: ctx.manifest_entry.content_type(),
partition_spec_id: ctx.partition_spec_id,
equality_ids: ctx.manifest_entry.data_file.equality_ids.clone(),
}
}
}
Expand All @@ -113,4 +114,7 @@ pub struct FileScanTaskDeleteFile {

/// partition id
pub partition_spec_id: i32,

/// equality ids for equality deletes (empty for positional deletes)
pub equality_ids: Vec<i32>,
}
Loading