Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions .github/workflows/release_python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,10 @@
name: Publish Python 🐍 distribution 📦 to PyPI

on:
push:
tags:
- "*"
pull_request:
branches:
- main
paths:
- ".github/workflows/release_python.yml"
workflow_run:
workflows: ["Publish"] # Trigger this workflow after the "publish.yml" workflow completes
types:
- completed
workflow_dispatch:

env:
Expand All @@ -39,8 +35,16 @@ permissions:
contents: read

jobs:
check-cargo-publish:
runs-on: ubuntu-latest
# Only run if the triggering workflow succeeded OR if manually triggered
if: ${{ github.event.workflow_run.conclusion == 'success' || github.event_name == 'workflow_dispatch' }}
steps:
- run: echo 'The Publish workflow passed or was manually triggered'

sdist:
runs-on: ubuntu-latest
needs: [check-cargo-publish]
steps:
- uses: actions/checkout@v4
- uses: PyO3/maturin-action@v1
Expand All @@ -56,6 +60,7 @@ jobs:

wheels:
runs-on: "${{ matrix.os }}"
needs: [check-cargo-publish]
strategy:
matrix:
include:
Expand Down Expand Up @@ -94,8 +99,8 @@ jobs:
name: Publish Python 🐍 distribution 📦 to Pypi
needs: [sdist, wheels]
runs-on: ubuntu-latest
# Only publish to PyPi if the tag is not a pre-release
if: ${{ startsWith(github.ref, 'refs/tags/') && !contains(github.ref, '-') }}
# Only publish to PyPi if the tag is not a pre-release OR if manually triggered
if: ${{ (startsWith(github.ref, 'refs/tags/') && !contains(github.ref, '-')) || github.event_name == 'workflow_dispatch' }}

environment:
name: pypi
Expand Down
1 change: 0 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion crates/iceberg/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ zstd = { workspace = true }
[dev-dependencies]
ctor = { workspace = true }
expect-test = { workspace = true }
iceberg-catalog-memory = { workspace = true }
iceberg_test_utils = { path = "../test_utils", features = ["tests"] }
pretty_assertions = { workspace = true }
rand = { workspace = true }
Expand Down
4 changes: 3 additions & 1 deletion crates/iceberg/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@
//!
//! ## Scan A Table
//!
//! ```rust, no_run
//! ```rust, ignore
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liurenjie1024 wdyt of using ignore here for now? i didnt want to remove all the docs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's fine to me.

//! // This example uses `iceberg_catalog_memory`, which isn't enabled by default.
//! // To run this, add `iceberg-catalog-memory` as a dependency in your Cargo.toml.
//! use futures::TryStreamExt;
//! use iceberg::io::{FileIO, FileIOBuilder};
//! use iceberg::{Catalog, Result, TableIdent};
Expand Down
8 changes: 6 additions & 2 deletions crates/iceberg/src/writer/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@
//! own writer and implement writer trait for them so that the custom writer can integrate with existing writer. (See following example)
//!
//! # Simple example for the data file writer used parquet physical format:
//! ```rust, no_run
//! ```rust, ignore
//! // This example uses `iceberg_catalog_memory`, which isn't enabled by default.
//! // To run this, add `iceberg-catalog-memory` as a dependency in your Cargo.toml.
//! use std::sync::Arc;
//!
//! use arrow_array::{ArrayRef, BooleanArray, Int32Array, RecordBatch, StringArray};
Expand Down Expand Up @@ -95,7 +97,9 @@
//! ```
//!
//! # Custom writer to record latency
//! ```rust, no_run
//! ```rust, ignore
//! // This example uses `iceberg_catalog_memory`, which isn't enabled by default.
//! // To run this, add `iceberg-catalog-memory` as a dependency in your Cargo.toml.
//! use std::time::Instant;
//!
//! use arrow_array::RecordBatch;
Expand Down
Loading