Skip to content

infra: use toml-cli to manually set version in github action #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025
Merged

infra: use toml-cli to manually set version in github action #1537

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45d2417
use toml-cli
kevinjqliu Jul 22, 2025
6df5671
fix mv
kevinjqliu Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions .github/workflows/release_python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,16 +87,19 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Install cargo-edit
- name: Install toml-cli
if: ${{ needs.validate-release-tag.outputs.is-rc == 'true' }}
run: cargo install cargo-edit
run: cargo install toml-cli

- name: Set cargo version for RC
if: ${{ needs.validate-release-tag.outputs.is-rc == 'true' }}
working-directory: "bindings/python"
run: |
echo "Setting cargo version to: ${{ needs.validate-release-tag.outputs.cargo-version }}"
cargo set-version ${{ needs.validate-release-tag.outputs.cargo-version }}
toml set Cargo.toml package.version ${{ needs.validate-release-tag.outputs.cargo-version }} > Cargo.toml.tmp
# doing this explicitly to avoid issue in Windows where `mv` does not overwrite existing file
rm Cargo.toml
mv Cargo.toml.tmp Cargo.toml

- uses: PyO3/maturin-action@v1
with:
Expand Down Expand Up @@ -127,16 +130,19 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Install cargo-edit
- name: Install toml-cli
if: ${{ needs.validate-release-tag.outputs.is-rc == 'true' }}
run: cargo install cargo-edit
run: cargo install toml-cli

- name: Set cargo version for RC
if: ${{ needs.validate-release-tag.outputs.is-rc == 'true' }}
working-directory: "bindings/python"
run: |
echo "Setting cargo version to: ${{ needs.validate-release-tag.outputs.cargo-version }}"
cargo set-version ${{ needs.validate-release-tag.outputs.cargo-version }}
toml set Cargo.toml package.version ${{ needs.validate-release-tag.outputs.cargo-version }} > Cargo.toml.tmp
# doing this explicitly to avoid issue in Windows where `mv` does not overwrite existing file
rm Cargo.toml
mv Cargo.toml.tmp Cargo.toml

- uses: actions/setup-python@v5
with:
Expand Down
Loading