test: pyiceberg-core, pin datafusion and unpin pyarrow #1648
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lliangyu-lin
approved these changes
Sep 5, 2025
liurenjie1024
approved these changes
Sep 5, 2025
sumanth-manchala
pushed a commit
to sumanth-manchala/iceberg-rust
that referenced
this pull request
Sep 6, 2025
## Which issue does this PR close? - Closes #. ## What changes are included in this PR? Follow up to apache#1635 We dont need to pin pyarrow specifically, just grab it from pyiceberg. Revert datafusion version threshold to 45. Version 45 is the lowest version which will still work. The underlying issue for apache#1635 is with the **newer** versions of datafusion, mainly datafusion 49 due to a breaking change described in apache#1647 So pyiceberg-core works with datafusion (python) library 45, 46, 47, and 48. just not 49 I verified locally with all the versions above: ``` hatch env prune && hatch run dev:test ``` i double checked. `insert_into` is available in datafusion 45. apache/datafusion@7f9a8c0 ## Are these changes tested?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Follow up to #1635
We dont need to pin pyarrow specifically, just grab it from pyiceberg.
Revert datafusion version threshold to 45. Version 45 is the lowest version which will still work.
The underlying issue for #1635 is with the newer versions of datafusion, mainly datafusion 49 due to a breaking change described in #1647
So pyiceberg-core works with datafusion (python) library 45, 46, 47, and 48. just not 49
I verified locally with all the versions above:
i double checked.
insert_intois available in datafusion 45. apache/datafusion@7f9a8c0Are these changes tested?