Skip to content

Conversation

kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Sep 4, 2025

Which issue does this PR close?

  • Closes #.

What changes are included in this PR?

reference https://datafusion.apache.org/blog/2025/07/16/datafusion-48.0.0/

cargo build
cargo test
cargo fmt --all
cd bindings/python
hatch env prune
hatch run dev:build
hatch run dev:test

Use cargo generate-lockfile -Z direct-minimal-versions -Z minimal-versions to check for min version, but dont use the Cargo.lock changes!

Are these changes tested?

@kevinjqliu
Copy link
Contributor Author

error building locally...

   Compiling datafusion-cli v48.0.1
error: expected `;`
  --> /Users/kevinliu/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/datafusion-substrait-48.0.1/src/physical_plan/consumer.rs:67:58
   |
67 |             let Some(schema) = read.base_schema.as_ref() else {
   |                                                          ^^^^

error: could not compile `datafusion-substrait` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

@kevinjqliu
Copy link
Contributor Author

closing in favor of #1501

@kevinjqliu kevinjqliu closed this Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant