Skip to content

Conversation

kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Sep 6, 2025

Which issue does this PR close?

  • Closes #.

What changes are included in this PR?

make check-toml and make cargo-machete already ensures the crates are installed.

iceberg-rust/Makefile

Lines 35 to 42 in 7362bbd

install-taplo-cli:
cargo install taplo-cli@0.9.3
fix-toml: install-taplo-cli
taplo fmt
check-toml: install-taplo-cli
taplo check

iceberg-rust/Makefile

Lines 29 to 33 in 7362bbd

install-cargo-machete:
cargo install cargo-machete@0.7.0
cargo-machete: install-cargo-machete
cargo machete

Resolves CI errror from Check toml format:

Run make check-toml
cargo install taplo-cli@0.9.3
    Updating crates.io index
 Downloading crates ...
  Downloaded taplo-cli v0.9.3
error: binary `taplo` already exists in destination
Add --force to overwrite
make: *** [install-taplo-cli] Error 101
Error: Process completed with exit code 2.

Are these changes tested?

Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinjqliu for this fix!

@liurenjie1024 liurenjie1024 merged commit c6dc48f into apache:main Sep 8, 2025
17 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/simplify-ci branch September 8, 2025 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants