infra: add check-msrv to Makefile #1680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Sep 17, 2025
kevinjqliu
commented
Sep 17, 2025
.github/workflows/ci.yml
Outdated
Comment on lines
162
to
167
| - name: Setup Nightly Rust toolchain | ||
| uses: ./.github/actions/setup-builder | ||
| - name: Setup MSRV Rust toolchain | ||
| uses: ./.github/actions/setup-builder | ||
| with: | ||
| rust-version: ${{ env.rust_msrv }} |
There was a problem hiding this comment.
needs both nightly and MSRV toolchain because
cargo generate-lockfile -Z direct-minimal-versions requires nightly specified by rust-toolchain.toml
cargo +1.87 check --locked --workspace then requires MSRV
kevinjqliu
commented
Sep 18, 2025
liurenjie1024
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Add
make check-msrvcommand to run the same MSRV check in CI and locallyAre these changes tested?
I verified by upgrading datafusion from 48 to 49 locally and continuously run
make check-msrv