docs: installation of the new iceberg_catalog_rest added to the docs
#355
Conversation
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thanks! We now have support for multiple catalogs. I'm guessing we need to reorganize the entire installation documentation. However, this PR itself is good to go.
|
Also cc @Fokko and @liurenjie1024 for a review. |
| </div> | ||
|
|
||
| Add `iceberg` into `Cargo.toml` dependencies: | ||
| Add `iceberg` and `iceberg-catalog-rest` into `Cargo.toml` dependencies: |
There was a problem hiding this comment.
How about splitting them into two sections as following:
Add `iceberg-catalog-rest` if you want to use rest catalog.
...
There was a problem hiding this comment.
Makes sense.
I'll push these changes in a day or two
|
cc @nishant-sachdeva Are you still working on this? |
|
Hi, @liurenjie1024, this PR has been open for a while without any progress. I believe it's ready to be merged and we can continue to make improvements on it afterward. What do you think about merging it as is? |
Seems @nishant-sachdeva is not responding. To be honest I still prefer to use different section for adding different dependencies. Or could we file other prs to add docs and close this pr first if @nishant-sachdeva doesn't have time to do the udpate? |
Understood.
@nishant-sachdeva has made some effort in this PR and I do want to include his contribution in. I will finish this work based on his work on this PR. |
3 participants
No description provided.