Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Extract partition_filters from ManifestEvaluator #360

Merged
merged 12 commits into from
Apr 30, 2024
10 changes: 5 additions & 5 deletions crates/iceberg/src/expr/predicate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ use crate::spec::{Datum, SchemaRef};
use crate::{Error, ErrorKind};

/// Logical expression, such as `AND`, `OR`, `NOT`.
#[derive(PartialEq)]
#[derive(PartialEq, Clone)]
pub struct LogicalExpression<T, const N: usize> {
inputs: [Box<T>; N],
}
Expand Down Expand Up @@ -79,7 +79,7 @@ where
}

/// Unary predicate, for example, `a IS NULL`.
#[derive(PartialEq)]
#[derive(PartialEq, Clone)]
pub struct UnaryExpression<T> {
/// Operator of this predicate, must be single operand operator.
op: PredicateOperator,
Expand Down Expand Up @@ -126,7 +126,7 @@ impl<T> UnaryExpression<T> {
}

/// Binary predicate, for example, `a > 10`.
#[derive(PartialEq)]
#[derive(PartialEq, Clone)]
pub struct BinaryExpression<T> {
/// Operator of this predicate, must be binary operator, such as `=`, `>`, `<`, etc.
op: PredicateOperator,
Expand Down Expand Up @@ -184,7 +184,7 @@ impl<T: Bind> Bind for BinaryExpression<T> {
}

/// Set predicates, for example, `a in (1, 2, 3)`.
#[derive(PartialEq)]
#[derive(PartialEq, Clone)]
pub struct SetExpression<T> {
/// Operator of this predicate, must be set operator, such as `IN`, `NOT IN`, etc.
op: PredicateOperator,
Expand Down Expand Up @@ -613,7 +613,7 @@ impl Not for Predicate {
}

/// Bound predicate expression after binding to a schema.
#[derive(Debug)]
#[derive(Debug, Clone)]
pub enum BoundPredicate {
/// An expression always evaluates to true.
AlwaysTrue,
Expand Down
Loading
Loading