feat: Expose length of Iterators #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-thiel
changed the title
|
Alternatively we could expose the Hashmaps directly? Those would provide a few more accessors than any proxy type |
liurenjie1024
approved these changes
Nov 11, 2024
I'm not a big fan of exposing concrete underlying data structures directly. I think we have provided enough look up methods such as get by id, is there any cases that can't be satisfied? |
|
I think we are good for now, thanks! |
twuebi
pushed a commit
to lakekeeper/iceberg-rust
that referenced
this pull request
Nov 11, 2024
ZENOTME
pushed a commit
to risingwavelabs/iceberg-rust
that referenced
this pull request
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
iceberg-rustwe currently have quite a fewIteratorsover fields without a lightweight option to determine length. InLakekeeperwe have some places where we need to know the length of fields - especially for theIteratorsused inTableMetadata. Usingxx_iter().count()isn't nice.It would be great if we could expose the
lenin a more straightforward way, either by explicit methods or by usingExactSizeIteratoras proposed in this PR.Let me know what you think!