feat: add s3tables catalog #807
Merged
+799
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaneur2020
force-pushed
the
add-s3tables
branch
from
52e5b72 to
25f5e2a
Compare
flaneur2020
force-pushed
the
add-s3tables
branch
from
6e1e958 to
d63d2d8
Compare
Member
|
Hi @flaneur2020, I suggest splitting this PR into multiple ones to make it easier to review and accelerate the iteration speed. |
Contributor
Author
|
@Xuanwo i believe the missing part of this pr is adding tests, i've created a real s3tables bucket to test it and it looks work fine, can you give some suggestions about the test part? i found the glue catalog is using a mock service from |
flaneur2020
force-pushed
the
add-s3tables
branch
from
d63d2d8 to
e63c4be
Compare
flaneur2020
force-pushed
the
add-s3tables
branch
from
e63c4be to
43dd573
Compare
flaneur2020
force-pushed
the
add-s3tables
branch
from
b6fcbee to
ad0160d
Compare
Xuanwo
reviewed
Dec 24, 2024
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thanks a lot for this PR, really great! Only some small suggestions.
Contributor
Author
|
@Xuanwo added comments on all the public apis, PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #754
this PR adds the implementation of s3tables catalog. i've tested the CRUD of namespaces/tables in my local laptop with a real s3tables bucket.
need to add a mocked test suites in ci in another pr.