chore: improve and fix the rest example #842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
approved these changes
Dec 24, 2024
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @goldmedal for adding this!
Contributor
Author
Thanks, @Xuanwo for the review 👍 |
| use iceberg_catalog_rest::{RestCatalog, RestCatalogConfig}; | ||
|
|
||
| /// This is a simple example that demonstrates how to create a table in a REST catalog and get it back. | ||
| /// It requires a running instance of the iceberg-rest catalog for the port 8080. |
Contributor
There was a problem hiding this comment.
I think that the 8080 here might be a typo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm a newer of iceberg and iceberg-rs. I'm not sure if I did it right 🤔
When I tried the example, I was confused about what I needed to prepare (e.g. rest catalog server)
I think it's good to add some doc for them.
Changed
I found the default port of the rest server is
8181. I'm not sure. If I'm wrong, please correct me.https://github.com/apache/iceberg/blob/d6d3cf58a99b99984a36802fcec078494ca4b46f/open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java#L42